✨: deepcopy: gen: match Go 1.17 build tag format #595

benpbrown · 2021-08-17T17:54:09Z

The Go team has started the process of replacing the old "// +build"
constraints with the new "//go:build" constraints. See the design
doc for more details here:

https://go.googlesource.com/proposal/+/master/design/draft-gobuild.md

What is relevant is that in Go 1.17, gofmt now synchronizes the two
styles. In particular, if gofmt is run against a deepcopy generated
file, it will add a new "//go:build" constraint.

See https://golang.org/doc/go1.17#gofmt for details.

This PR intends to make it so that the generated code is compliant with
the new gofmt style.

Relevant issue: #594

The Go team has started the process of replacing the old "// +build" constraints with the new "//go:build" constraints. See the design doc for more details here: https://go.googlesource.com/proposal/+/master/design/draft-gobuild.md What is relevant is that in Go 1.17, gofmt now synchronizes the two styles. In particular, if gofmt is run against a deepcopy generated file, it will add a new "//go:build" constraint. See https://golang.org/doc/go1.17#gofmt for details. This PR intends to make it so that the generated code is compliant with the new gofmt style.

k8s-ci-robot · 2021-08-17T17:54:12Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2021-08-17T17:54:17Z

Welcome @benpbrown!

It looks like this is your first PR to kubernetes-sigs/controller-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

benpbrown · 2021-08-17T17:55:51Z

I have signed the CLA.

benpbrown · 2021-08-24T16:18:05Z

Gentle ping for review @mengqiy @droot

benpbrown · 2021-08-31T19:02:42Z

Gentle ping for for review from the reviewers group (@droot @mengqiy @pwittrock @vincepri)

benpbrown · 2021-09-07T16:01:01Z

Ping for review @droot @mengqiy @pwittrock @vincepri

benpbrown · 2021-09-15T16:12:52Z

/assign @mengqiy

benpbrown · 2021-09-15T16:12:59Z

Ping for review @droot @mengqiy @pwittrock @vincepri

camilamacedo86 · 2021-09-19T07:26:25Z

IHMO we need to update first k8s then controller runtime and then we can do this update here. See: operator-framework/operator-sdk#5208 (comment)

benpbrown · 2021-09-20T17:09:14Z

Hi @camilamacedo86 thanks for your message.

I understand that it would be desirable to upgrade the Go version used to compile Kubernetes (and related repos) all at once, but I don't quite follow the connection to this PR.

This PR doesn't use Go 1.17 for building controller-tools (it still uses 1.16). The change is in the codegen emitted by controller-tools, which becomes forwards compatible with 1.17.

Happily, the emitted code is backwards compatible with Go 1.16 (Go 1.16 added support for the new style build tags), so contributors will continue to use Go 1.16 on this repo.

camilamacedo86 · 2021-12-13T23:19:59Z

/ok-to-test

pkg/deepcopy/gen.go

camilamacedo86

/lgtm

k8s-triage-robot · 2022-03-14T02:03:26Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

benpbrown · 2022-03-14T02:40:29Z

/remove-lifecycle stale

k8s-ci-robot · 2022-05-06T03:30:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, benpbrown

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [alvaroaleman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

alvaroaleman · 2022-05-06T03:30:32Z

/close

k8s-ci-robot · 2022-05-06T03:30:42Z

@alvaroaleman: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alvaroaleman · 2022-05-06T03:30:50Z

/reopen
(to trigger the CLA bot)

k8s-ci-robot · 2022-05-06T03:31:00Z

@alvaroaleman: Reopened this PR.

In response to this:

/reopen
(to trigger the CLA bot)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Update all current build tags `// +build` to new format accepted in go 1.17 `//go:build`. `zz_generated.deepcopy.go` files contains both tags because `controller-tools` does the migration smoothly (kubernetes-sigs/controller-tools#595).

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 17, 2021

k8s-ci-robot requested review from droot and mengqiy August 17, 2021 17:54

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 17, 2021

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 17, 2021

benpbrown changed the title ~~deepcopy: gen: match Go 1.17 build tag format (✨)~~ deepcopy: gen: match Go 1.17 build tag format (✨) ✨ Aug 17, 2021

benpbrown changed the title ~~deepcopy: gen: match Go 1.17 build tag format (✨) ✨~~ ✨: deepcopy: gen: match Go 1.17 build tag format Aug 17, 2021

tklauser mentioned this pull request Aug 19, 2021

Update Go to 1.17 cilium/cilium#17190

Merged

twpayne mentioned this pull request Sep 6, 2021

treewide: Ensure that binaries are built with at least Go 1.17 cilium/cilium#17322

Merged

tklauser mentioned this pull request Sep 6, 2021

deepcopy: gen: match Go 1.17 build tag format christarazi/controller-tools#1

Merged

k8s-ci-robot assigned mengqiy Sep 15, 2021

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 13, 2021

camilamacedo86 reviewed Dec 13, 2021

View reviewed changes

pkg/deepcopy/gen.go Show resolved Hide resolved

camilamacedo86 reviewed Dec 14, 2021

View reviewed changes

k8s-ci-robot assigned camilamacedo86 Dec 14, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2021

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 14, 2022

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 14, 2022

alvaroaleman approved these changes May 6, 2022

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2022

k8s-ci-robot closed this May 6, 2022

k8s-ci-robot reopened this May 6, 2022

k8s-ci-robot merged commit a260f13 into kubernetes-sigs:master May 6, 2022

thbkrkr mentioned this pull request May 24, 2022

Move to new golang 1.17 build tag format elastic/cloud-on-k8s#5692

Merged

✨: deepcopy: gen: match Go 1.17 build tag format #595

✨: deepcopy: gen: match Go 1.17 build tag format #595

Uh oh!

Conversation

benpbrown commented Aug 17, 2021

Uh oh!

k8s-ci-robot commented Aug 17, 2021

Uh oh!

k8s-ci-robot commented Aug 17, 2021

Uh oh!

benpbrown commented Aug 17, 2021

Uh oh!

benpbrown commented Aug 24, 2021

Uh oh!

benpbrown commented Aug 31, 2021

Uh oh!

benpbrown commented Sep 7, 2021

Uh oh!

benpbrown commented Sep 15, 2021

Uh oh!

benpbrown commented Sep 15, 2021

Uh oh!

camilamacedo86 commented Sep 19, 2021

Uh oh!

benpbrown commented Sep 20, 2021

Uh oh!

camilamacedo86 commented Dec 13, 2021

Uh oh!

Uh oh!

camilamacedo86 left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-triage-robot commented Mar 14, 2022

Uh oh!

benpbrown commented Mar 14, 2022

Uh oh!

k8s-ci-robot commented May 6, 2022

Uh oh!

alvaroaleman commented May 6, 2022

Uh oh!

k8s-ci-robot commented May 6, 2022

Uh oh!

alvaroaleman commented May 6, 2022

Uh oh!

k8s-ci-robot commented May 6, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants